Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure a validator exists #75

Merged
merged 3 commits into from
Jul 4, 2023

Conversation

hmajid2301
Copy link
Contributor

In the RegisterTagNameFunc make sure the validator exists,
before trying to assign a func to it. Also updated comment to fix small typos.

In the RegisterTagNameFunc make sure the validator exists,
before trying to assign a func to it.
Fix the comment for RegisterTagNameFunc.
@hmajid2301
Copy link
Contributor Author

hmajid2301 commented Jun 30, 2021

Any update on this PR ? @loopfz

@hmajid2301
Copy link
Contributor Author

Hi any update on this ?

Copy link

@sgburtsev sgburtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed it in the same way.

@mcorbin
Copy link

mcorbin commented Jul 1, 2022

I'm also interested by this fix.
@loopfz what do you think about it ?

mcorbin added a commit to mcorbin/gadgeto that referenced this pull request Jul 1, 2022
In the RegisterTagNameFunc make sure the validator exists,
before trying to assign a func to it. Also updated comment to fix small typos.

loopfz#75
@wI2L wI2L merged commit 30eb770 into loopfz:master Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants