Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to loopback-next 1.0.0, also enabled streaming support #32

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

lhr0909
Copy link

@lhr0909 lhr0909 commented Oct 26, 2018

Description

We would like to use the package to create gRPC endpoints, but we found a few issues, mostly due to dependency not being up-to-date.

Related issues

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

"build:apidocs": "lb-apidocs",
"build:watch": "lb-tsc es2017 --watch",
"build:watch": "lb-tsc es2017 --outDir dist --watch",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the test script to be:

"test": "lb-mocha \"dist/test/unit/**/*.js\" \"dist/test/acceptance/**/*.js\"",

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raymondfeng Just fixed.

@lhr0909
Copy link
Author

lhr0909 commented Oct 27, 2018

I kinda went ahead and worked on the streaming calls generation. I am using the gRPC types, which they extend from the NodeJS's Readable, Writeable and Duplex streams. Should work just fine.

@lhr0909 lhr0909 mentioned this pull request Oct 27, 2018
@lhr0909 lhr0909 changed the title Upgrade to loopback-next 1.0.0 Upgrade to loopback-next 1.0.0, also enabled streaming support Oct 27, 2018
@raymondfeng
Copy link
Contributor

raymondfeng commented Mar 11, 2019

@lhr0909 Sorry for the long delay. Would you like to rebase it on top of master branch? I have fixed the project dependencies and set up. It would be great to have your streaming support.

Please also sign the CLA - https://cla.strongloop.com/agreements/strongloop/loopback4-extension-grpc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants