Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: specify that declarative test demo is for LB 3.x #848

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

emonddr
Copy link
Contributor

@emonddr emonddr commented Jun 13, 2019

Specify that the declarative test demo is for LoopBack 3.x

Related to : loopbackio/loopback-next#2940

This is about this link: https://loopback.io/doc/en/community/Declarative-test-demo.html

I spoke with @bajtos about this community example, since it mentioned Authenticated Requests.
I am working on updating documents related to authentication.
I wasn't sure if this project was still in use, and so I asked @bajtos .

Miroslav looked into it, and It turns out it is only for LoopBack 3.x .

He suggested:

Miroslav Bajtos  [1 hour ago]
It would be great to update
https://github.com/strongloop/loopback.io/blob/gh-pages/pages/en/community/Declarative-test-demo.md 
to make it clear that this community-contributed component/example is for LB 3.x

@emonddr emonddr requested a review from bschrammIBM as a code owner June 13, 2019 14:36
@emonddr emonddr requested review from b-admike, nabdelgadir, jannyHou and dhmlau and removed request for bschrammIBM June 13, 2019 14:37
Specify that the declarative test demo is only for LoopBack 3.x
@emonddr emonddr force-pushed the dremond_docs_declarative_test_demo branch from 25e2aa9 to e4d0683 Compare June 13, 2019 14:43
@@ -75,3 +77,4 @@ npm run test-watch
## Requirements

- Node >= 8
- LoopBack 3.x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: IMO this line is needed, but feel free to keep it.

@emonddr emonddr removed request for jannyHou and dhmlau June 13, 2019 16:59
@emonddr emonddr merged commit 4abe9ea into gh-pages Jun 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the dremond_docs_declarative_test_demo branch June 13, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants