Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove update-v4-readmes.sh #770

Merged
merged 1 commit into from
Nov 16, 2018
Merged

Remove update-v4-readmes.sh #770

merged 1 commit into from
Nov 16, 2018

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Nov 15, 2018

loopback-next was recently changed to bundle all READMEs inside @loopback/docs package published to npm, see loopbackio/loopback-next#2025. There is no need to copy v4 READMEs.

@bajtos bajtos added this to the November 2018 Milestone milestone Nov 15, 2018
@bajtos bajtos self-assigned this Nov 15, 2018
@bajtos bajtos requested review from b-admike and a team November 15, 2018 12:13
@bajtos bajtos requested a review from bschrammIBM as a code owner November 15, 2018 12:13
loopback-next was recently changed to bundle all READMEs
inside `@loopback/docs` package published to npm.
@bajtos bajtos force-pushed the remove-update-v4-readmes branch from 44a50f8 to e6b8438 Compare November 16, 2018 09:14
Copy link
Contributor

@b-admike b-admike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@bajtos bajtos merged commit 2da4d6a into gh-pages Nov 16, 2018
@bajtos bajtos deleted the remove-update-v4-readmes branch November 16, 2018 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants