-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update governance page #766
Conversation
pages/en/contrib/Governance.md
Outdated
@@ -20,18 +20,22 @@ Each repository has one or more lead maintainers responsible for: | |||
* Seeking consensus on technical decisions. | |||
* Making the final decisions when consensus cannot be achieved. | |||
|
|||
Maintainers have npm publishing rights for modules and the final say on releasing new versions. | |||
Maintainers have npm publishing rights for modules and the final say on releasing new versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I think this is not true. AFAIK, we don't give npm publishing rights to maintainers from the community. I am proposing to change "Maintainers" to "Lead maintainers" in this sentence to avoid possible confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right.
How to define/find out who are the "lead maintainers"? I'm thinking, as @jjtang1 suggested, whether it's better to have "core maintainers" (i.e. the core LB team) and "community maintainers"?
pages/en/contrib/Governance.md
Outdated
|
||
## Lead maintainers | ||
Refer to `CODEOWNERS` file in each repository for the list of lead maintainers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the term "active maintainers" instead of "lead maintainers". We list community members in CODEOWNERS too.
pages/en/contrib/Governance.md
Outdated
* [Miroslav Bajtoš](https://github.com/bajtos) | ||
* [Raymond Feng](https://github.com/raymondfeng) | ||
* [Ritchie Martori](https://github.com/ritch) | ||
* [Simon Ho](https://github.com/superkhau) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a new section "Alumni" towards the end and list people that are no longer actively working on the project there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One concern of adding the alumni section is that there is probably a much bigger list (it's likely we'll miss out a few?) that we try to keep track of it through the CODEOWNERS file.
If we want to keep Ritchie and Simon on this page because they have significant contributions to LB, we can put it as "previous project architects"?
pages/en/contrib/Governance.md
Outdated
|
||
For more details, see [Functional area owners](functional-area-owners.html). | ||
Full-time maintainers include: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should either:
- be explicit about the fact that this list contains people on IBM payroll only
- or include all current maintainers
I feel the current proposal is making community contributors a kind of second-class maintainers.
It would be great if we could fetch an up-to-date list of people from somewhere else (or point readers to such source), e.g. GitHub's list of people in @strongloop/loopback-maintainers
teams. Unfortunately, AFAICT, there is no such public view :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for pointing it out. I didn't realize it will cause this impression!
@bajtos, thanks for your feedback. I've made some changes based on your feedback.
I am a bit reluctant to create the alumni list because:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Co-Authored-By: dhmlau <[email protected]>
Related to loopbackio/loopback-next#1673