Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update governance page #766

Merged
merged 3 commits into from
Nov 13, 2018
Merged

update governance page #766

merged 3 commits into from
Nov 13, 2018

Conversation

dhmlau
Copy link
Member

@dhmlau dhmlau commented Nov 10, 2018

Related to loopbackio/loopback-next#1673

  • Update maintainer list
  • Remove functional owner page and its references, inform users to use CODEOWNERS file to determine the maintainers for the repo

@dhmlau dhmlau requested a review from bschrammIBM as a code owner November 10, 2018 22:12
@@ -20,18 +20,22 @@ Each repository has one or more lead maintainers responsible for:
* Seeking consensus on technical decisions.
* Making the final decisions when consensus cannot be achieved.

Maintainers have npm publishing rights for modules and the final say on releasing new versions.
Maintainers have npm publishing rights for modules and the final say on releasing new versions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think this is not true. AFAIK, we don't give npm publishing rights to maintainers from the community. I am proposing to change "Maintainers" to "Lead maintainers" in this sentence to avoid possible confusion.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right.
How to define/find out who are the "lead maintainers"? I'm thinking, as @jjtang1 suggested, whether it's better to have "core maintainers" (i.e. the core LB team) and "community maintainers"?


## Lead maintainers
Refer to `CODEOWNERS` file in each repository for the list of lead maintainers.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the term "active maintainers" instead of "lead maintainers". We list community members in CODEOWNERS too.

* [Miroslav Bajtoš](https://github.com/bajtos)
* [Raymond Feng](https://github.com/raymondfeng)
* [Ritchie Martori](https://github.com/ritch)
* [Simon Ho](https://github.com/superkhau)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a new section "Alumni" towards the end and list people that are no longer actively working on the project there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One concern of adding the alumni section is that there is probably a much bigger list (it's likely we'll miss out a few?) that we try to keep track of it through the CODEOWNERS file.
If we want to keep Ritchie and Simon on this page because they have significant contributions to LB, we can put it as "previous project architects"?


For more details, see [Functional area owners](functional-area-owners.html).
Full-time maintainers include:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should either:

  • be explicit about the fact that this list contains people on IBM payroll only
  • or include all current maintainers

I feel the current proposal is making community contributors a kind of second-class maintainers.

It would be great if we could fetch an up-to-date list of people from somewhere else (or point readers to such source), e.g. GitHub's list of people in @strongloop/loopback-maintainers teams. Unfortunately, AFAICT, there is no such public view :(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for pointing it out. I didn't realize it will cause this impression!

@dhmlau
Copy link
Member Author

dhmlau commented Nov 12, 2018

@bajtos, thanks for your feedback. I've made some changes based on your feedback.
I'd like to propose to have 2 categories of maintainers:

  • core maintainers, i.e. LoopBack core team (the 7 of us)
  • community maintainers, i.e. maintainers, regardless IBMers or not, who have made substantial amount of contributions in LB

I am a bit reluctant to create the alumni list because:

  1. the alumni list is a much bigger list that we are trying to keep track in the CODEOWNERS file already.
  2. while we value the contributions of the alumni maintainers had made, it may not be too relevant to community users who come to this page to find out the current active maintainers.

Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

pages/en/contrib/Governance.md Outdated Show resolved Hide resolved
@dhmlau dhmlau merged commit 45911af into gh-pages Nov 13, 2018
@dhmlau dhmlau deleted the contribute branch November 13, 2018 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants