-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lb(fix): remove multiple component binding sugar #619
Conversation
shimks
commented
Feb 13, 2018
- connected to Decouple wiring of implementation bits from application configuration loopback-next#742
pages/en/lb4/Application.md
Outdated
``` | ||
The components collection allows bulk binding of component constructors within | ||
The components collection allows binding of component constructors within |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's no longer a collection ... but idk what else you can change it to.
pages/en/lb4/Application.md
Outdated
``` | ||
Much like the components collection, the controllers collection allows bulk | ||
binding of [Controllers](Controllers.html) to | ||
Much like the components collection, the controllers collection allows binding of [Controllers](Controllers.html) to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same. Not a collection.
#### Controllers | ||
```ts | ||
app.controller(FooController); | ||
app.controller(BarController); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it mean app.controller
no longer takes in an array of controller ctor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It never did in the first place. The change is being made to a WIP PR that got accidentally merged, and since that feature (registration of array of controllers) is no longer being implemented, I'm reverting that portion of the PR.
#### Servers | ||
```ts | ||
app.server(RestServer); | ||
app.servers([MyServer, GrpcServer]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we eventually get rid of app.servers()
(the plural version) for consistency? It's out of scope of this pull request though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that would be a good idea ... at least till we have plans to re-visit multi-server support.