Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add osx to build matrix #949

Merged
merged 1 commit into from
Feb 1, 2018
Merged

ci: add osx to build matrix #949

merged 1 commit into from
Feb 1, 2018

Conversation

b-admike
Copy link
Contributor

@b-admike b-admike commented Feb 1, 2018

This PR looks to add osx to our travis build matrix. It gives us more platform coverage, but is also used as a way to fix build issue arising from #948.

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Related API Documentation was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in packages/example-* were updated

Co-Authored-by: Taranveer Virk <[email protected]>
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Please wait for CI results to become green before landing.

On an unrelated note, I noticed that we are running our commit-linter on Node.js 6.x, can we eventually switch to 8.x instead?

@virkt25
Copy link
Contributor

virkt25 commented Feb 1, 2018

Once 6 is dropped from the node_js matrix, 8 will become the default for commit-linter.

@b-admike b-admike merged commit 25b8ee1 into master Feb 1, 2018
@b-admike b-admike deleted the ci/add-osx branch February 1, 2018 16:06
@b-admike b-admike mentioned this pull request Feb 1, 2018
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants