fix(rest): Improve rest metadata inheritance #746
Conversation
| ); | ||
|
|
||
| // The parent endpoint has been overridden | ||
| expect(childSpec.paths).to.not.have.property('/name'); |
There was a problem hiding this comment.
Good catch. Fixed.
Make sure metadata inherited from base classes are cloned to avoid pollution of base information
raymondfeng
force-pushed
the
fix-rest-metadata-inheritance
branch
from
0b5dce9 to
91e3367
Compare
| @@ -73,6 +86,20 @@ interface RestEndpoint { | |||
| target: any; | |||
| } | |||
|
|
|||
| function getEndpoints( | |||
There was a problem hiding this comment.
Can we please have ts docs for this function? (or maybe we don't need it because it's internal?
|
|
||
| const {verb, path} = endpoint; | ||
| const endpointName = `${fullMethodName} (${verb} ${path})`; | ||
| const verb = endpoint.verb!; |
There was a problem hiding this comment.
For my understanding, what does having a ! at the end of this statement do?
| const path = endpoint.path!; | ||
|
|
||
| let endpointName = ''; | ||
| if (debug.enabled) { |
|
|
||
| let endpoint: Partial<RestEndpoint> = endpoints[propertyKey]; | ||
| if (!endpoint) { | ||
| const endpoints = getEndpoints(target); |
There was a problem hiding this comment.
Should we change the tsdocs for this function to say that child classes can override REST operations?
|
|
||
| let endpoint: Partial<RestEndpoint> = endpoints[propertyKey]; | ||
| if (!endpoint) { | ||
| const endpoints = getEndpoints(target); |
There was a problem hiding this comment.
ditto: should we change ts-docs for this function to say that child classes can override REST parameters?
| @@ -26,8 +26,6 @@ | |||
| "@loopback/context": "^4.0.0-alpha.20", | |||
| "@loopback/core": "^4.0.0-alpha.22", | |||
| "@loopback/openapi-spec": "^4.0.0-alpha.15", | |||
| "@types/http-errors": "^1.5.34", | |||
There was a problem hiding this comment.
This needs to be in dependencies because we re-export the http-errors objects for use in @loopback/rest.
Removing this will cause compilation failures downstream!
|
Unfortunately, we (myself and reviewers) and the CI build didn't catch the error when it was merged. |
Make sure metadata inherited from base classes are cloned to avoid
pollution of base information
Description
Related issues
Checklist