Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [RFC] Allow sequence to be composed from actions with class/method dependency injection #713

Closed
wants to merge 1 commit into from

Conversation

raymondfeng
Copy link
Contributor

The PR adds the ability to declare action classes/methods and utilizes dependencies to create a sequence of actions.

  • Add @action to decorate action classes and methods and use corresponding metadata to determine the order of invocation so that we can build a sequence.

  • Add invokeMethod to invoke a prototype method of a given class with dependency injection

Description

Connect to #139

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

@raymondfeng raymondfeng changed the base branch from master to method-di November 9, 2017 19:05
@raymondfeng raymondfeng force-pushed the method-di branch 2 times, most recently from 3031497 to 7d1264e Compare November 9, 2017 19:22
@raymondfeng raymondfeng closed this Nov 9, 2017
@raymondfeng raymondfeng removed the review label Nov 9, 2017
@raymondfeng raymondfeng reopened this Nov 9, 2017
@raymondfeng raymondfeng added review and removed review labels Nov 9, 2017
@raymondfeng raymondfeng changed the base branch from method-di to master November 11, 2017 01:38
@bajtos bajtos added the non-MVP label Jan 25, 2018
@raymondfeng raymondfeng changed the title Action composition [WIP] [RFC] Allow sequence to be composed from actions with class/method dependency injection Feb 1, 2018
Add @action to decorate action classes and methods and use corresponding
metadata to determine the order of invocation so that we can build a
sequence.
@bajtos
Copy link
Member

bajtos commented Oct 26, 2018

There have been no updates in this pull request for many months, I am closing it for now. @raymondfeng feel free to reopen if you get time to continue this work. (Considering how outdated these changes are, it may be better to start from scratch.)

@bajtos bajtos closed this Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants