Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): update FAQ #6469

Merged
merged 1 commit into from
Oct 9, 2020
Merged

feat(docs): update FAQ #6469

merged 1 commit into from
Oct 9, 2020

Conversation

achrinza
Copy link
Member

This PR is part of a larger initiative to incrementally improve the documentation.

Signed-off-by: Rifa Achrinza [email protected]

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@achrinza achrinza self-assigned this Sep 30, 2020
@achrinza achrinza force-pushed the docs/update-faq branch 3 times, most recently from e09e311 to 353dac3 Compare September 30, 2020 07:32
dhmlau
dhmlau reviewed Sep 30, 2020
View reviewed changes
Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@achrinza, thanks for the PR. The PR is generally LGTM. I have a comment about VSCode, please see my review comment. Thanks.

docs/site/FAQ.md Outdated Show resolved Hide resolved
dhmlau
dhmlau approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please fix the typo.

docs/site/FAQ.md Outdated Show resolved Hide resolved
bajtos
bajtos approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great initiative, @achrinza 👏🏻

The changes looks mostly good, I have few ideas to consider.

docs/site/FAQ.md Show resolved Hide resolved
docs/site/FAQ.md Outdated Show resolved Hide resolved
@achrinza @dhmlau
feat(docs): update FAQ
bb1ab34 
Co-authored-by: Diana Lau <[email protected]>
Signed-off-by: Rifa Achrinza <[email protected]>
@dhmlau
Copy link
Member

dhmlau commented Oct 9, 2020

@achrinza, since this PR has 2 approvals, I'm going to merge it. Thanks!

@dhmlau dhmlau merged commit 7d4a3e2 into loopbackio:master Oct 9, 2020
@achrinza achrinza deleted the docs/update-faq branch October 9, 2020 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos approved these changes

@dhmlau dhmlau dhmlau approved these changes

Assignees

@achrinza achrinza

Labels
Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achrinza @dhmlau @bajtos