feat(authentication-jwt): add bear auth spec enhancer #5493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jannyHou
changed the title
7 tasks
raymondfeng
approved these changes
May 20, 2020
dougal83
reviewed
May 20, 2020
| ]; | ||
|
|
||
| export const SECURITY_SCHEME_SPEC: SecuritySchemeObjects = { | ||
| bearerAuth: { |
There was a problem hiding this comment.
Should this not be jwt: {
Excuse me if I'm going mad! 😋
There was a problem hiding this comment.
Oh, my bad memory! I remember there was one PR to rename it, and I thought the rename is from jwt ---> bearerAuth, so wrote it as bearerAuth....
Then I find #4461, it's actually the reverse, from bearerAuth ---> jwt
😲 😲
Will correct it in the next refactor PR, coming soon.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #4386
Add bear auth spec enhancer, refactor the component to apply enhancer automatically.
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈