Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update "LB4 Component Migration" spike proposal #5427

Merged
merged 1 commit into from
May 15, 2020

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented May 14, 2020

Link to follow-up issues for the following areas:

Propose to not write any migration guide for auth/auth extensions yet.

Add a placeholder page for migration of Models, finalize LB4 sidebar and the component-migration overview page.

This pull request resolves most of the remaining tasks in #4099 with the exception of "Migrate Models, Entities and Repositories", for which I'll open a new pull request (I have some content to include in the migration docs).

@raymondfeng @jannyHou @emonddr: please review

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

Link to follow-up issues for the following areas:

- Services: #5424
- API transports: #5425
- Instrospection: #5426

Propose to not write any migration guide for auth/auth extensions yet.

Add a placeholder page for migration of Models, finalize LB4 sidebar
and the component-migration overview page.

Signed-off-by: Miroslav Bajtoš <[email protected]>
example)._
_LB3 typically uses component configuration. I think in LB4, we can use
`@configure` specific to each service (see the logger extension for an
example)._
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those two blocks are just whitespace changes, I removed the extra - bullet point.

will need to decide if it's enough to inject LB4 Repository to a component
or if we need to inject model/entity classes too. Also note that
`DefaultCrudReposiory` class provides a public instance property
`entityClass` referencing the model/entity it's bound to._
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the text to accommodate #5361

@bajtos bajtos mentioned this pull request May 14, 2020
11 tasks
@bajtos bajtos self-assigned this May 14, 2020
@bajtos bajtos merged commit 205d3aa into master May 15, 2020
@bajtos bajtos deleted the spike/migrate-components-update branch May 15, 2020 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants