[SPIKE] DO NOT MERGE feat: try mw with passport login example #5302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondfeng
reviewed
May 1, 2020
|
|
||
| @intercept('PassportInitMW') | ||
| @intercept('PassportSessionMW') | ||
| @intercept('FacebookOauth2MW') |
There was a problem hiding this comment.
It can be simplified as @intercept('PassportInitMW', 'PassportSessionMW', 'FacebookOauth2MW').
raymondfeng
reviewed
May 1, 2020
| @@ -91,3 +97,34 @@ export const mapProfile = function (user: User): UserProfile { | |||
| }; | |||
| return userProfile; | |||
| }; | |||
|
|
|||
| export class PassportInitMW implements Provider<Interceptor> { | |||
There was a problem hiding this comment.
There is no need to wrap a simple Express middleware as provider class for local interceptors. You simply bind it to the context, or create a binding for it:
app.bind('PassportInitMW').to(toInterceptor(passport.initialize());
// or
const binding = new Binding('PassportInitMW').to(toInterceptor(passport.initialize());
…ware - add `Middleware` as interceptors that use request context - add `InvokeMiddleware` to invoke middleware in a chain - add extension points for Middleware extensions - add helper methods to adapt express middleware as interceptors - add helper methods to adapt LoopBack middleware chain as Express middleware - add ExpressServer and ExpressApplication to extend Express with LoopBack core
- add `InvokeMiddleware` action to the default sequence - add `middleware/expressMiddleware` APIs to RestServer/RestApplication - use middleware APIs to register CORS and OpenAPI spec endpoints BREAKING CHANGE: `basePath` now also applies to endpoints that serve OpenAPI specs. For example, the OpenAPI specs are available at `/api/openapi.json` or `/api/openapi.yaml` if the base path is set to `/api`.
raymondfeng
force-pushed
the
middleware-interceptor
branch
from
c97955f to
2539258
Compare
deepakrkris
force-pushed
the
express-passport-middleware
branch
from
59d2891 to
16bce44
Compare
raymondfeng
reviewed
May 1, 2020
| constructor( | ||
| ) {} | ||
|
|
||
| @intercept('passport-init-mw', 'passport-session-mw', 'passport-facebook') |
There was a problem hiding this comment.
It is possible to define a custom decorator such as:
export function facebookLogin() {
return intercept('passport-init-mw', 'passport-session-mw', 'passport-facebook');
}Then we can use @facebookLogin().
|
Nice and clean. 👍 |
raymondfeng
force-pushed
the
middleware-interceptor
branch
8 times, most recently
from
abc2ee8 to
7970266
Compare
deepakrkris
force-pushed
the
express-passport-middleware
branch
from
bda5b70 to
3931b3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example for #5118
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈