Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(apiconnect): add x-ibm-name to OpenAPI info object #5266

Merged
merged 2 commits into from
Apr 27, 2020
Merged

feat(apiconnect): add x-ibm-name to OpenAPI info object #5266

merged 2 commits into from
Apr 27, 2020

Conversation

raymondfeng
Copy link
Contributor

@raymondfeng raymondfeng commented Apr 27, 2020 •
edited
Loading

Fixes #5259

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

deepakrkris
deepakrkris approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@deepakrkris deepakrkris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets try to get the default value for x-ibm-name from the app's package.json

@raymondfeng raymondfeng merged commit 20d29a3 into master Apr 27, 2020
@raymondfeng raymondfeng deleted the fix-apiconnect branch April 27, 2020 17:20
@bajtos bajtos changed the title Fix https://github.com/strongloop/loopback-next/issues/5259 Add x-ibm-name to OpenAPI info object May 14, 2020
@bajtos bajtos changed the title Add x-ibm-name to OpenAPI info object feat(apiconnect): add x-ibm-name to OpenAPI info object May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepakrkris deepakrkris deepakrkris approved these changes

@emonddr emonddr emonddr approved these changes

@bajtos bajtos Awaiting requested review from bajtos

@jannyHou jannyHou Awaiting requested review from jannyHou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

loopback apiconnect extension must add x-ibm-name to info header in api spec
3 participants
@raymondfeng @emonddr @deepakrkris