New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update bin/create-package.js to be compatible with TypeScript project references #5208

Merged

raymondfeng merged 1 commit into master from fix-create-package

Apr 23, 2020

Contributor

raymondfeng commented Apr 23, 2020 •

edited

Loading

See #4984 (review)

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

npm test passes on your machine
New tests added or existing tests modified to cover all changes
Code conforms with the style guide
API Documentation in code was updated
Documentation in /docs/site was updated
Affected artifact templates in packages/cli were updated
Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈


          feat: update bin/create-package.js to be compatible with TypeScript p…

fe50a0c

…roject references

raymondfeng requested review from agnes512, bajtos, deepakrkris, emonddr, hacksparrow, jannyHou and nabdelgadir as code owners

April 23, 2020 15:06

jannyHou approved these changes

View reviewed changes

emonddr approved these changes

View reviewed changes

raymondfeng merged commit eb057ef into master

raymondfeng deleted the fix-create-package branch

April 23, 2020 17:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jannyHou jannyHou approved these changes

emonddr emonddr approved these changes

agnes512 Awaiting requested review from agnes512

bajtos Awaiting requested review from bajtos

deepakrkris Awaiting requested review from deepakrkris

hacksparrow Awaiting requested review from hacksparrow

nabdelgadir Awaiting requested review from nabdelgadir

Labels

None yet