Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] feat(docs): add April milestone #4906

Closed
wants to merge 3 commits into from
Closed

Conversation

dhmlau
Copy link
Member

@dhmlau dhmlau commented Mar 17, 2020

April milestone

  • committed 35 pts for now.

Overall theme:

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@dhmlau dhmlau self-assigned this Mar 17, 2020
@dhmlau dhmlau requested review from raymondfeng and bajtos March 17, 2020 20:00

- [ ] From model definition to REST API #3935

- [ ] CLI command to expose REST API of a Model with no custom classes #2739
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is done now 👍

@dhmlau
Copy link
Member Author

dhmlau commented Mar 25, 2020

@deepakrkris, I've made the last update in this PR. This can be used as the base for creating a milestone GH issue. Thanks!
The following issues might be still working in progress when April comes, if so, please add it to the GH issue too.

@derdeka
Copy link
Contributor

derdeka commented Mar 27, 2020

I would like to ask for some feedback to #4438 to get hasManyThrough completed in April?

@dhmlau
Copy link
Member Author

dhmlau commented Mar 27, 2020

I would like to ask for some feedback to #4438 to get hasManyThrough completed in April?

@derdeka, sure. If your PR is ready for review, could you please make it a PR instead of a draft PR? Thanks.


- [ ] From model definition to REST API #3935

- [ ] Docs for exposing REST API of a Model with no custom classes #2740
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

landed! 👍


- PR reviews
- [ ] feat(repository): hasManyThrough #4438

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepakrkris, can we also add the following task as well pls? Thanks.
Extract the jwt authentication to an extension module #4903

@bajtos
Copy link
Member

bajtos commented Mar 30, 2020

@dhmlau @raymondfeng I would like us to resume the work on enabling TypeScript Project References in loopback-next, see #2609. TypeScript 3.8 should have fixed the issue(s) blocking us from adoption of this feature, and the upcoming 3.9 version is fixing few other edge cases (we can update to TypeScript 3.9 beta to start using those goodies early).


- Aim at finish the
[Migration guide epic](https://github.com/strongloop/loopback-next/issues/3935)
excpet for the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Suggested change
excpet for the
except for the

- [ ] Spike: How to migrate LB3 components #4099
- [ ] How to map LB3 CLI commands to LB4 CLI #3953
- [ ] Spike: How to migrate apps using loopback-component-oauth2 #3959
- [ ] How to run LB3 app tests when the app is mounted in a LB4 project #3978
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepakrkris, please replace #3978 with:
Spike: how to run LB3 tests from LB4 when LB3 is mounted on the LB4 app #5004

since we've created a spike on it. thanks.

@agnes512
Copy link
Contributor

agnes512 commented Apr 1, 2020

Slipped:

@dhmlau
Copy link
Member Author

dhmlau commented Apr 1, 2020

Closing as #5010 is opened.

@dhmlau dhmlau closed this Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants