Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor/acl migration #4827

Merged
merged 3 commits into from
Mar 9, 2020
Merged

refactor/acl migration #4827

merged 3 commits into from
Mar 9, 2020

Conversation

jannyHou
Copy link
Contributor

@jannyHou jannyHou commented Mar 9, 2020 •
edited
Loading

connect to #4753

Please review with "hide white space changes". And you can review by commits.

Refactored the casbin-auth and jwt-auth services into 2 components:

  • /components
    • /casbin-authorization
      • /services
        • /...files
    • /jwt-authentication
      • /services
        • /...files

And update docs accordingly.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

dhmlau
dhmlau reviewed Mar 9, 2020
View reviewed changes
docs/site/migration/auth/example.md Outdated Show resolved Hide resolved
docs/site/migration/auth/example.md Outdated Show resolved Hide resolved
@jannyHou jannyHou force-pushed the doc/acl-migration branch from 041039c to 2e59a15 Compare March 9, 2020 18:42
@jannyHou jannyHou changed the title Doc/acl migration refactor/acl migration Mar 9, 2020
agnes512
agnes512 approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@agnes512 agnes512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@jannyHou jannyHou force-pushed the doc/acl-migration branch from 2e59a15 to 0df5469 Compare March 9, 2020 19:08
@jannyHou jannyHou merged commit 807e804 into master Mar 9, 2020
@jannyHou jannyHou deleted the doc/acl-migration branch March 9, 2020 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnes512 agnes512 agnes512 approved these changes

@dhmlau dhmlau dhmlau approved these changes

@raymondfeng raymondfeng raymondfeng approved these changes

@bajtos bajtos Awaiting requested review from bajtos

@deepakrkris deepakrkris Awaiting requested review from deepakrkris

@emonddr emonddr Awaiting requested review from emonddr

@hacksparrow hacksparrow Awaiting requested review from hacksparrow

@nabdelgadir nabdelgadir Awaiting requested review from nabdelgadir nabdelgadir is a code owner

Assignees
No one assigned
Labels
Docs Migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jannyHou @raymondfeng @dhmlau @agnes512