-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(example-file-upload): add an example for file upload with LoopBack 4 #4801
Conversation
733cf6a
to
c2335f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @raymondfeng for creating this example!
I wonder if it would be better to somehow show what got uploaded even it's in memory. I tried the example but I don't know a way to verify it actually got uploaded, or maybe I'm just missing something. :)
c2335f7
to
167a029
Compare
+1 to add a way for inspecting the uploaded files |
acbf740
to
ee5b949
Compare
I switch to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the upload location is updated in code or README.
283b8a0
to
4cfbe3f
Compare
b1e3623
to
5806d0d
Compare
A suggestion for future example apps. The changes required for the example should be in a separate commit, so we have a good visibility about the amount of changes that goes into making the feature work. |
5806d0d
to
7bd0521
Compare
01013af
to
7deceb6
Compare
7deceb6
to
d3f5cd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on local LGTM 👍
d3f5cd3
to
33abb04
Compare
An example app for file upload.
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated👉 Check out how to submit a PR 👈