fix(cli): correct root directory in test #4652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes error on windows tests. Removes instances of sandbox folder erroniously placed in packages folder. See loopbackio#4425 Signed-off-by: Douglas McConnachie <[email protected]>
|
Thank you for the pull request. I think it may be an intentional decision to place the sandbox directory into AFAICT, one of the problematic tests was introduced by 6302101 by @agnes512. Agnes, do you happen to remember what was your intention? What is the correct |
|
I think @dougal83 is right. The test was supposed to be tested in sandbox. I made a mistake, my bad D: |
agnes512
approved these changes
Feb 14, 2020
dougal83
added a commit
to dougal83/loopback-next
that referenced
this pull request
Feb 15, 2020
ensure test app is remove afterward follows: loopbackio#4652 Signed-off-by: Douglas McConnachie <[email protected]>
3 tasks
dougal83
added a commit
to dougal83/loopback-next
that referenced
this pull request
Feb 15, 2020
ensure test app is remove afterward follows: loopbackio#4652 Signed-off-by: Douglas McConnachie <[email protected]>
dougal83
added a commit
to dougal83/loopback-next
that referenced
this pull request
Feb 17, 2020
ensure test app is remove afterward follows: loopbackio#4652 Signed-off-by: Douglas McConnachie <[email protected]>
raymondfeng
pushed a commit
that referenced
this pull request
Feb 17, 2020
ensure test app is remove afterward follows: #4652 Signed-off-by: Douglas McConnachie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes error on windows tests. Removes instances of sandbox folder
erroniously placed in packages folder.
See #4425
Signed-off-by: Douglas McConnachie [email protected]
Checklist
npm testpasses on your machine