Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(extension-logging): fix typos and clean up descriptions #4575

Merged
merged 1 commit into from
Feb 6, 2020
Merged

chore(extension-logging): fix typos and clean up descriptions #4575

merged 1 commit into from
Feb 6, 2020

Conversation

raymondfeng
Copy link
Contributor

@raymondfeng raymondfeng commented Feb 6, 2020 •
edited
Loading

Addresses #4117 (comment)

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@raymondfeng raymondfeng force-pushed the fix-logging-typo branch 2 times, most recently from 35c5607 to 7f697d6 Compare February 6, 2020 17:15
dhmlau
dhmlau approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the typo in the folder for fluent.acceptance.ts is not fixed yet. Other than that, LGTM.

@raymondfeng raymondfeng merged commit 78f1ee1 into master Feb 6, 2020
@raymondfeng raymondfeng deleted the fix-logging-typo branch February 6, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnes512 agnes512 agnes512 approved these changes

@nabdelgadir nabdelgadir nabdelgadir approved these changes

@dhmlau dhmlau dhmlau approved these changes

@jannyHou jannyHou jannyHou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@raymondfeng @jannyHou @dhmlau @nabdelgadir @agnes512