Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependency ts-morph to v6 #4274

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 8, 2019

This PR contains the following updates:

Package Type Update Change
ts-morph dependencies major ^5.0.0 -> ^6.0.2

Release Notes

dsherret/ts-morph

v6.0.2

Compare Source

v6.0.1

Compare Source


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

Newsflash: Renovate has joined WhiteSource, and is now free for all use. Learn more or view updated terms and privacy policies.

@renovate renovate bot requested review from bajtos and raymondfeng as code owners December 8, 2019 02:14
@renovate renovate bot force-pushed the renovate/ts-morph-6.x branch from 7c29c7c to 2747f23 Compare December 8, 2019 03:07
@bajtos bajtos added the 2020Q1 label Dec 12, 2019
@renovate renovate bot force-pushed the renovate/ts-morph-6.x branch from 2747f23 to a01350f Compare December 12, 2019 13:05
@bajtos
Copy link
Member

bajtos commented Dec 12, 2019

Cross-posting from ts-morph's CHANGELOG, I am not able to asses impact of these changes on our CLI - I hope our test suite is good enough to catch any problems.

BREAKING CHANGES

  • JSDoc#setComment(...) and #getComment(...) are now setDescription(...) and getDescription(). They also work according to Static file serve in loopback 4 #764.
  • StructureTypeGuards is now Structure.
  • PropertyDeclarationDeclaration and PropertyDeclarationStructure now can have a declare keyword (new in TS 3.7).
  • JS docs will be written as a single line unless multi-line or starting with a newline. Additionally, getting a JS doc structure will have a newline at the start if the JS doc description is one line, but the JS doc is multi-line.
  • ProjectOptions#useVirtualFileSystem is now useInMemoryFileSystem. This is a more accurate name.
  • Creating a Project with useInMemoryFileSystem: true will now load in the lib files into the node_modules/typescript/lib folder.
  • Due to the fix for Angular5 SDK #702, when using Project#addSourceFileAtPaths directories that do not have an ancestor directory with a source file included in the results will no longer be added to the project. If you want to ensure that a directory and all its subfolders are added, use Project#addDirectoryAtPath(path, { recursive: true }).
  • FileSystemHost#glob is now asynchronous and #globSync was added.
  • Renamed Directory/Project#addExistingSourceFile -> addSourceFileAtPath
  • Renamed Directory/Project#addExistingSourceFileIfExists -> addSourceFileAtPathIfExists
  • Renamed Directory/Project#addExistingSourceFiles -> addSourceFilesAtPaths
  • Renamed Directory/Project#addExistingDirectory -> addDirectoryAtPath
  • Renamed Directory/Project#addExistingDirectoryIfExists -> addDirectoryAtPathIfExists

@bajtos
Copy link
Member

bajtos commented Dec 12, 2019

And here comes the first problem reported by our CI:

AssertionError: expected [Promise] to be rejected with a message matching /Target model primary key does not exist/, but got 'project.addExistingSourceFile is not a function'
  at next$onError (packages\testlab\node_modules\should\as-function.js:1799:14)
  at <anonymous>

@dhmlau dhmlau added this to the Jan 2020 milestone Dec 19, 2019
@renovate renovate bot force-pushed the renovate/ts-morph-6.x branch from a01350f to 4e375b5 Compare December 25, 2019 21:29
@renovate renovate bot force-pushed the renovate/ts-morph-6.x branch from 4e375b5 to 427ea8f Compare January 7, 2020 17:50
@bajtos bajtos self-assigned this Jan 9, 2020
Signed-off-by: Renovate Bot <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
@bajtos bajtos force-pushed the renovate/ts-morph-6.x branch from 427ea8f to 92822e6 Compare January 9, 2020 08:32
@bajtos bajtos merged commit bb8fd82 into master Jan 9, 2020
@bajtos bajtos deleted the renovate/ts-morph-6.x branch January 9, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants