Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add a skeleton of migration guide #3922

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Oct 14, 2019

A skeleton of our migration guide, laying down the overall structure and creating placeholder pages that will be filled in later in follow-up pull requests.

Important: I am not aiming at covering all aspects of LB3 application development. This pull request is meant as the first step to allow incremental improvements in the (near) future.

Screenshot of the (final) sidebar Screen Shot 2019-10-17 at 14 02 10

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@bajtos bajtos added this to the Oct 2019 milestone milestone Oct 14, 2019
@bajtos bajtos requested review from raymondfeng, dhmlau and a team October 14, 2019 14:39
@bajtos bajtos self-assigned this Oct 14, 2019
@bajtos
Copy link
Member Author

bajtos commented Oct 14, 2019

One thing I am debating with myself: should the sidebar entries start with Migrating prefix (e.g. Migrating datasources)? I find that very repetitive and prefer to leave that prefix out (e.g. Datasources nested inside Migration guide).

@richardpringle
Copy link

Can't wait to see those TODOs filled in 😉

@aharbis
Copy link
Contributor

aharbis commented Oct 15, 2019

I find that very repetitive and prefer to leave that prefix out (e.g. Datasources nested inside Migration guide).

@bajtos I agree. I do not think it's necessary to prefix all entries with Migrating.


This is a great start to the migration guide! Speaking as someone who still has a large LoopBack 3 application that we still need to migrate, I feel this covers a large majority of the topics in question.

In LoopBack 3 we rely heavily on operation hooks and remote hooks to implement the vast majority of business logic (excluding of course remote methods). Understanding the life cycle differences between request processing in LoopBack 3 and LoopBack 4 is I think a critical point that many would benefit from.

@bajtos
Copy link
Member Author

bajtos commented Oct 15, 2019

@aharbis thank you for the feedback.

Understanding the life cycle differences between request processing in LoopBack 3 and LoopBack 4 is I think a critical point that many would benefit from.

This is a great suggestion. Can you please open a new issue where we can discuss further details?

@bajtos bajtos force-pushed the docs/migration-guide-skeleton branch from 6ee3892 to 5027cd6 Compare October 15, 2019 12:02
@emonddr
Copy link
Contributor

emonddr commented Oct 15, 2019

One thing I am debating with myself: should the sidebar entries start with Migrating prefix (e.g. Migrating datasources)? I find that very repetitive and prefer to leave that prefix out (e.g. Datasources nested inside Migration guide).

Each subtopic of the Migration Guide (parent topic) in the sidebar should avoid using 'Migrating' over and over. But if the user does navigate to 'Migration Guide -> Models , for example, the title of that document should be "Migrating Models". Just so it is clear what the intention of the document is; especially if user performs a search on "Models" and ends up on that page...it should be clear that the purpose is migrating models as opposed to creating models.

@bajtos

This comment has been minimized.

@dhmlau
Copy link
Member

dhmlau commented Oct 15, 2019

LGTM. There are 2 questions that show up from time to time, I wonder if it is covered by the current plan.

  1. can we continue to use loopback-component-storage in LB4?
  2. can we continue to use the LoopBack supported connectors in LB4?
    For the database connectors, we probably don't need a section because it is supposed to continue to work. So maybe we add a note somewhere to make sure we state that?

Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 2 questions in #3922 (comment).

@bajtos
Copy link
Member Author

bajtos commented Oct 15, 2019

@dhmlau

LGTM. There are 2 questions that show up from time to time, I wonder if it is covered by the current plan.

Good questions! I can cover them in the overview document.

  1. can we continue to use loopback-component-storage in LB4?

No, this is also mentioned in "Understanding the differences".

It makes me wonder: should we create a dedicated page to list all components & features that we don't plan to migrate to LB4?

  1. can we continue to use the LoopBack supported connectors in LB4?
    For the database connectors, we probably don't need a section because it is supposed to continue to work. So maybe we add a note somewhere to make sure we state that?

I think the best place for this information is the page describing how to migrate datasources.

I can also add a short mention to the migration overview.

@dhmlau
Copy link
Member

dhmlau commented Oct 15, 2019

It makes me wonder: should we create a dedicated page to list all components & features that we don't plan to migrate to LB4?

+1. It would be even better if we provide the alternatives.

Copy link
Contributor

@raymondfeng raymondfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a great list that covers most of LB3 features.

Maybe add one section to cover some of the lb CLI commands, such as lb swagger and lb soap.

@bajtos
Copy link
Member Author

bajtos commented Oct 17, 2019

I addressed the review comments above, added text to overview pages, created follow-up issues and updated placeholder pages with links.

The pull request is ready for final review & landing.

@raymondfeng @dhmlau @emonddr @strongloop/sq-lb-apex PTAL.

@bajtos
Copy link
Member Author

bajtos commented Oct 17, 2019

(I'll clean up the commit history after the changes are approved.)

@bajtos bajtos changed the title docs: add a skeleton of migration guide [WIP] docs: add a skeleton of migration guide Oct 17, 2019
Copy link
Contributor

@agnes512 agnes512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how migration/overview.md guilds LB3 users to migrate to LB4 by learning the differences and the limitations step by step.

@bajtos bajtos force-pushed the docs/migration-guide-skeleton branch from 8fe8412 to 1ef5b1c Compare October 18, 2019 05:56
@bajtos
Copy link
Member Author

bajtos commented Oct 18, 2019

The test failures are unrelated to my changes, it looks like the US Census geocoding service is not available (hopefully only temporarily).

Cannot proxy GET https://geocoding.geo.census.gov/geocoder/locations/onelineaddress?format=json&benchmark=Public_AR_Current&address=1%20New%20Orchard%20Road%2C%20Armonk%2C%2010504.
RequestError: Error: getaddrinfo ENOTFOUND geocoding.geo.census.gov

@bajtos bajtos merged commit 9def622 into master Oct 18, 2019
@bajtos bajtos deleted the docs/migration-guide-skeleton branch October 18, 2019 06:53
@bajtos bajtos mentioned this pull request Nov 11, 2019
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants