-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add a skeleton of migration guide #3922
Conversation
One thing I am debating with myself: should the sidebar entries start with |
Can't wait to see those |
@bajtos I agree. I do not think it's necessary to prefix all entries with This is a great start to the migration guide! Speaking as someone who still has a large LoopBack 3 application that we still need to migrate, I feel this covers a large majority of the topics in question. In LoopBack 3 we rely heavily on operation hooks and remote hooks to implement the vast majority of business logic (excluding of course remote methods). Understanding the life cycle differences between request processing in LoopBack 3 and LoopBack 4 is I think a critical point that many would benefit from. |
@aharbis thank you for the feedback.
This is a great suggestion. Can you please open a new issue where we can discuss further details? |
6ee3892
to
5027cd6
Compare
Each subtopic of the Migration Guide (parent topic) in the sidebar should avoid using 'Migrating' over and over. But if the user does navigate to 'Migration Guide -> Models , for example, the title of that document should be "Migrating Models". Just so it is clear what the intention of the document is; especially if user performs a search on "Models" and ends up on that page...it should be clear that the purpose is migrating models as opposed to creating models. |
This comment has been minimized.
This comment has been minimized.
LGTM. There are 2 questions that show up from time to time, I wonder if it is covered by the current plan.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with 2 questions in #3922 (comment).
Good questions! I can cover them in the overview document.
No, this is also mentioned in "Understanding the differences". It makes me wonder: should we create a dedicated page to list all components & features that we don't plan to migrate to LB4?
I think the best place for this information is the page describing how to migrate datasources. I can also add a short mention to the migration overview. |
+1. It would be even better if we provide the alternatives. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a great list that covers most of LB3 features.
Maybe add one section to cover some of the lb
CLI commands, such as lb swagger
and lb soap
.
09917e8
to
8fe8412
Compare
I addressed the review comments above, added text to overview pages, created follow-up issues and updated placeholder pages with links. The pull request is ready for final review & landing. @raymondfeng @dhmlau @emonddr @strongloop/sq-lb-apex PTAL. |
(I'll clean up the commit history after the changes are approved.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how migration/overview.md
guilds LB3 users to migrate to LB4 by learning the differences and the limitations step by step.
Signed-off-by: Miroslav Bajtoš <[email protected]>
8fe8412
to
1ef5b1c
Compare
The test failures are unrelated to my changes, it looks like the US Census geocoding service is not available (hopefully only temporarily).
|
A skeleton of our migration guide, laying down the overall structure and creating placeholder pages that will be filled in later in follow-up pull requests.
Important: I am not aiming at covering all aspects of LB3 application development. This pull request is meant as the first step to allow incremental improvements in the (near) future.
Screenshot of the (final) sidebar
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated👉 Check out how to submit a PR 👈