Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(repository): add keyFrom to resolved relation metadata #3726

Merged
merged 3 commits into from
Sep 17, 2019
Merged

feat(repository): add keyFrom to resolved relation metadata #3726

merged 3 commits into from
Sep 17, 2019

Conversation

nabdelgadir
Copy link
Contributor

@nabdelgadir nabdelgadir commented Sep 13, 2019 •
edited
Loading

Resolves #3441.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@nabdelgadir nabdelgadir force-pushed the keyfrom branch 2 times, most recently from 62f803e to d5c73e3 Compare September 14, 2019 00:49
@nabdelgadir nabdelgadir self-assigned this Sep 14, 2019
@nabdelgadir nabdelgadir marked this pull request as ready for review September 14, 2019 01:06
jannyHou
jannyHou reviewed Sep 16, 2019
View reviewed changes
Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nabdelgadir Nice PR to include keyFrom in the metadata. LGTM in general 👍 just left a comment about the type definition.

...s/repository/src/__tests__/integration/repositories/resolve-has-many-metadata.integration.ts Outdated Show resolved Hide resolved
agnes512
agnes512 reviewed Sep 16, 2019
View reviewed changes
Copy link
Contributor

@agnes512 agnes512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost looks good to me, I only commented onhasMany since they are similar.

...s/repository/src/__tests__/integration/repositories/resolve-has-many-metadata.integration.ts Outdated Show resolved Hide resolved
...s/repository/src/__tests__/integration/repositories/resolve-has-many-metadata.integration.ts Outdated Show resolved Hide resolved
jannyHou
jannyHou approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 LGTM :shipit:

@nabdelgadir nabdelgadir merged commit f058920 into master Sep 17, 2019
@nabdelgadir nabdelgadir deleted the keyfrom branch September 17, 2019 14:54
@agnes512 agnes512 mentioned this pull request Sep 17, 2019
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnes512 agnes512 agnes512 approved these changes

@jannyHou jannyHou jannyHou approved these changes

@raymondfeng raymondfeng raymondfeng approved these changes

@bajtos bajtos Awaiting requested review from bajtos

Assignees

@nabdelgadir nabdelgadir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add keyFrom to resolved relation metadata
4 participants
@nabdelgadir @raymondfeng @jannyHou @agnes512