Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(repository-tests): unify the usage of MixedIdType for all tests #3647

Merged
merged 1 commit into from
Sep 3, 2019
Merged

fix(repository-tests): unify the usage of MixedIdType for all tests #3647

merged 1 commit into from
Sep 3, 2019

Conversation

agnes512
Copy link
Contributor

@agnes512 agnes512 commented Sep 3, 2019

Unifies the usage of MixedIdType for all tests in repository-tests.
MixedIdType is introduced in #3538

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@agnes512 agnes512 force-pushed the refactor-tests-fixup branch from 35e85b4 to 097fd56 Compare September 3, 2019 13:22
@agnes512 agnes512 marked this pull request as ready for review September 3, 2019 13:37
emonddr
emonddr approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@emonddr emonddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@agnes512 agnes512 merged commit 0548651 into master Sep 3, 2019
@agnes512 agnes512 deleted the refactor-tests-fixup branch September 3, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannyHou jannyHou jannyHou approved these changes

@emonddr emonddr emonddr approved these changes

@bajtos bajtos Awaiting requested review from bajtos

@raymondfeng raymondfeng Awaiting requested review from raymondfeng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agnes512 @emonddr @jannyHou