Add @loopback/security #3551
Merged
Add @loopback/security #3551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jannyHou, for the decreased in code coverage, is there something we can do about it? Thanks. |
raymondfeng
reviewed
Aug 16, 2019
| subject.addUser(user); | ||
| expect(subject.user).to.eql(user); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Let's add tests for addApplication and addCredential etc.
|
@dhmlau @raymondfeng Tests added :) |
raymondfeng
reviewed
Aug 19, 2019
packages/security/docs.json
Outdated
| "src/**/*.ts" | ||
| ], | ||
| "codeSectionDepth": 4 | ||
| } |
There was a problem hiding this comment.
This file should be removed as we no longer use strong-docs.
raymondfeng
reviewed
Aug 19, 2019
packages/security/package.json
Outdated
| "build": "lb-tsc", | ||
| "clean": "lb-clean loopback-authorization*.tgz dist package *.tsbuildinfo", | ||
| "integration": "lb-mocha \"dist/__tests__/integration/**/*.js\"", | ||
| "prepublishOnly": "npm run build && npm run build:apidocs", |
There was a problem hiding this comment.
This line should be removed.
raymondfeng
reviewed
Aug 19, 2019
packages/security/package.json
Outdated
| "scripts": { | ||
| "acceptance": "lb-mocha \"dist/__tests__/acceptance/**/*.js\"", | ||
| "build": "lb-tsc", | ||
| "clean": "lb-clean loopback-authorization*.tgz dist package *.tsbuildinfo", |
There was a problem hiding this comment.
It should be:
"clean": "lb-clean loopback-security*.tgz dist package *.tsbuildinfo",
raymondfeng
reviewed
Aug 19, 2019
packages/security/package.json
Outdated
| "@loopback/build": "^1.5.2", | ||
| "@loopback/testlab": "^1.2.7", | ||
| "@types/debug": "^4.1.4", | ||
| "@types/node": "10.14.15", |
raymondfeng
reviewed
Aug 19, 2019
packages/security/package.json
Outdated
| ], | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/strongloop/loopback-next.git" |
There was a problem hiding this comment.
Add "directory": "packages/security"
raymondfeng
reviewed
Aug 19, 2019
| "type": "git", | ||
| "url": "https://github.com/strongloop/loopback-next.git" | ||
| } | ||
| } |
There was a problem hiding this comment.
Let's compare with an existing module such as @loopback/context to make sure the package.json is consistent.
jannyHou
force-pushed
the
feat/security
branch
from
444d889 to
e03fc39
Compare
raymondfeng
approved these changes
Aug 20, 2019
jannyHou
force-pushed
the
feat/security
branch
from
e03fc39 to
3aebb9a
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2900
cherry-picked from #2902
Create a shared layer for
@loopback/authenticationand@loopback/authorization, which defines the security information(context) and binding keys forSubjectand its members.For reviewers:
This PR is migrated from draft #2902.
It contains a comprehensive design of the security system (now
@loopback/authenticationand@loopback/authorizationonly share interfaceUserProfile)So we have different plans for implementing the security module:
PrincipleandUserProfile(which extends Principle) in this PR.Principle, let's at least extract the existingUserProfileinterface here as the first release.Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈