Rename CrudConnectorFeatures to CrudFeatures #3411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacksparrow
approved these changes
Jul 22, 2019
In the future, we are likely to add options that are specific to different Repository implementations, in addition to connector-specific options. Let's rename the interface to describe this enlarged scope. Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
bajtos
force-pushed
the
feat/rename-crud-options
branch
from
5671664 to
4a4e182
Compare
nabdelgadir
approved these changes
Jul 22, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future (see #3387), we are likely to add options that are specific to different Repository implementations, in addition to connector-specific options. Let's rename the interface to describe this enlarged scope.
The second commit adds "acceptance" packages like
acceptance/repository-mongodbtotsconfig.jsonused by VSCode. Before this change, refactor-rename was not applied to packages inacceptancedirectory.Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈