fix(rest): correctly handle basePath set via basePath() API

[bajtos]

• Fix server.basePath() method to update basePath in the config object too.
• This fixes the server url in openapi.json to include basePath again.
• Add more test to verify the changes and prevent future regressions

See #914

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

• npm test passes on your machine
• New tests added or existing tests modified to cover all changes
• Code conforms with the style guide
• API Documentation in code was updated
• Documentation in /docs/site was updated
• Affected artifact templates in packages/cli were updated
• Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

[nabdelgadir]

I tried it by adding this.basePath('/api') to application.ts in the todo example, but it's still not updating it in /openapi.json:

----------

Here's the explorer (the url is using /api):

[bajtos]

I tried it by adding this.basePath('/api') to application.ts in the todo example, but it's still not updating it in /openapi.json:

That's weird! Did you rebuild the entire monorepo?

Here is how I am editing examples/todo/src/application.ts myself:

diff --git a/examples/todo/src/application.ts b/examples/todo/src/application.ts
index 9ee0dc68..566e3137 100644
--- a/examples/todo/src/application.ts
+++ b/examples/todo/src/application.ts
@@ -18,6 +18,8 @@ export class TodoListApplication extends BootMixin(
   constructor(options: ApplicationConfig = {}) {
     super(options);

+    this.basePath('/api');
+
     // Set up the custom sequence
     this.sequence(MySequence);

And here is a screenshot from the API Explorer:

@nabdelgadir can you try one more time please?

[nabdelgadir]

LGTM 👍

[AnanthGopal]

Hi @bajtos
I added the this.basePath('/api') into application.ts but it's still not updating it in /openapi.json

[AnanthGopal]

hi @raymondfeng ,
When releasing this feature? As of now, i can't use swagger because i added base path in my loopback application by using this.basePath('/api') that aren't reflected in /openapi.json.

Server url like below(https://127.0.0.1/)
https://user-images.githubusercontent.com/42985749/60344156-e0099280-9983-11e9-838b-4a1eb45889be.png

https://user-images.githubusercontent.com/42985749/60344373-5efecb00-9984-11e9-8ca5-dd7d11ff0c98.png

I need servers url like(https://127.0.0.1/api/)
https://user-images.githubusercontent.com/1140553/60504408-d5bc0100-9cc1-11e9-9fc0-25f1d1ef8040.png

[raymondfeng]

The feature should have been released for a while now.

[AnanthGopal]

thank you @raymondfeng . Eagerly i am waiting for this feature.