fix(cli): fix app default project name. untildify the project path

[agnes512]

Description

In the issue 2092, the default project name could be generated incorrectly if the cwd folder name has hyphens, fixed. The input app name has no such issue.

The user also suggested that lb4 should allow the project to be generated in the CWD. However, that could be messy and confusing. The other issue is that lb4 allows user to use any project path as they want. This could be problematic:

(CWD: User/lb4-app)
? Project name: pathFromRoot
? Project root directory:  ~/try/pathFromRoot
...
Application pathFromRoot was created in ~/try/pathFromRoot

lb4-app$ ls
~
lb4-app$ cd ~
[goes to the root folder]

The change here is to untildify the input path to make sure that it always uses absolute path.

resolves #2092

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

• npm test passes on your machine
• New tests added or existing tests modified to cover all changes
• Code conforms with the style guide
• API Documentation in code was updated
• Documentation in /docs/site was updated
• Affected artifact templates in packages/cli were updated
• Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

[raymondfeng]

The user also suggested that lb4 should allow the project to be generated in the CWD. However, that could be messy and confusing.

I agree. Can the user type . for his case?

[b-admike]

Nice fix 👍. Can we add a test for the changes?

[agnes512]

The user also suggested that lb4 should allow the project to be generated in the CWD. However, that could be messy and confusing.

I agree. Can the user type . for his case?

Yes, . and .. both work. That's why I mention the CWD in the warning msg. I will make the message more clear.

[bajtos]

LGTM at high level, I'll leave the detailed review to others.

It would be great to add tests to cover the new behavior and prevent regressions in the future.

[raymondfeng]

See https://github.com/strongloop/loopback-next/pull/3252/files#r302179837