Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update sample todo and todo-lists #3201

Merged
merged 1 commit into from
Jun 21, 2019
Merged

fix: update sample todo and todo-lists #3201

merged 1 commit into from
Jun 21, 2019

Conversation

nabdelgadir
Copy link
Contributor

See #3171 (comment).

Updated the sample instances to be less political, while keeping a similar theme.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@nabdelgadir nabdelgadir mentioned this pull request Jun 21, 2019
Merged
7 tasks
bajtos
bajtos approved these changes Jun 21, 2019
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@nabdelgadir nabdelgadir merged commit 99d3aa0 into master Jun 21, 2019
@delete-merged-branch delete-merged-branch bot deleted the update-sample-todos branch June 21, 2019 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhmlau dhmlau dhmlau approved these changes

@bajtos bajtos bajtos approved these changes

@raymondfeng raymondfeng Awaiting requested review from raymondfeng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nabdelgadir @bajtos @dhmlau