Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: point to new authentication component doc link #3147

Merged
merged 1 commit into from
Jun 14, 2019
Merged

docs: point to new authentication component doc link #3147

merged 1 commit into from
Jun 14, 2019

Conversation

emonddr
Copy link
Contributor

@emonddr emonddr commented Jun 13, 2019 •
edited
Loading

Point to new Authentication component document

Related to #2940

Instead of pointing to @loopback/authentication/README.MD, point to
new authentication component document.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@emonddr emonddr requested review from b-admike, nabdelgadir, dhmlau, bajtos and agnes512 and removed request for raymondfeng and bajtos June 13, 2019 13:11
bajtos
bajtos approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@emonddr emonddr force-pushed the dremond_docs_fix_auth_decorator branch from 7d4564e to 5f33616 Compare June 13, 2019 13:40
@emonddr emonddr removed request for dhmlau and agnes512 June 13, 2019 13:40
@emonddr emonddr force-pushed the dremond_docs_fix_auth_decorator branch from 5f33616 to 15a0c1c Compare June 13, 2019 17:02
@emonddr
docs: point to new authentication component doc link
a3b9034 
Point to new Authentication component document
@emonddr emonddr force-pushed the dremond_docs_fix_auth_decorator branch from 15a0c1c to a3b9034 Compare June 14, 2019 02:22
@emonddr emonddr merged commit 7ea2ad6 into master Jun 14, 2019
@delete-merged-branch delete-merged-branch bot deleted the dremond_docs_fix_auth_decorator branch June 14, 2019 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabdelgadir nabdelgadir nabdelgadir approved these changes

@b-admike b-admike b-admike approved these changes

@bajtos bajtos bajtos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emonddr @bajtos @b-admike @nabdelgadir