chore: revert https://github.com/strongloop/loopback-next/pull/2976

[raymondfeng]

Revert #2976

@jannyHou Please try the following:

cd loopback-next
npm run clean:lerna
rm -rf node_modules
npm i
npm run build

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

• npm test passes on your machine
• New tests added or existing tests modified to cover all changes
• Code conforms with the style guide
• API Documentation in code was updated
• Documentation in /docs/site was updated
• Affected artifact templates in packages/cli were updated
• Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

[jannyHou]

Thanks Raymond I run into that problem with a newly cloned loopback-next. I remember the cmds I run are:

npm i
npm test

I agree that the argument here should be a handler, my fix was in a wrong direction. I am trying your cmds now but not sure if they could fix the build error.

The function overloading here expects the argument to be an Application not handler.

[raymondfeng]

@jannyHou

export interface IRouterMatcher<T> {
    (path: PathParams, ...handlers: RequestHandler[]): T;
    (path: PathParams, ...handlers: RequestHandlerParams[]): T;
    (path: PathParams, subApplication: Application): T;
}

The interface above allows (path, handler) and our code is compatible with it.