test(cli): fix lerna bootstrap to link monorepo packages
#2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lerna v3.10.3 changed the way how `lerna bootstrap --scope` works, breaking our CLI tests when changes are made in dependencies of newly scaffolded projects. This commit fixes the problem by adding `--force-local` option to restore previous behavior. Also to make future troubleshooting easier, I am changing lerna log level used by the test from "silent" to "warn". Signed-off-by: Miroslav Bajtoš <[email protected]>
|
At the moment, the following extra output is printed by our tests to stderr: It should go away once lerna/lerna#2104 is landed and released. |
2 tasks
|
Good catch. I ran into this issue a few times. For example, for the api-extractor integration, |
raymondfeng
approved these changes
May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lerna v3.10.3 changed the way how
lerna bootstrap --scopeworks, breaking our CLI tests when changes are made in dependencies of newly scaffolded projects. (As I discovered while working on #2928).This commit fixes the problem by adding
--force-localoption to restore previous behavior, see lerna/lerna@71174e4709. Unfortunately,--force-localis broken now, we need to wait until lerna/lerna#2104 is merged and released.Also to make future troubleshooting easier, I am changing lerna log level used by the test from "silent" to "warn".
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈