Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(context): adjust resolvers to accept a non-optional session #2745

Merged
merged 1 commit into from
Apr 12, 2019
Merged

chore(context): adjust resolvers to accept a non-optional session #2745

merged 1 commit into from
Apr 12, 2019

Conversation

raymondfeng
Copy link
Contributor

@raymondfeng raymondfeng commented Apr 12, 2019 •
edited
Loading

A follow-up to #2711

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@raymondfeng raymondfeng requested a review from bajtos as a code owner April 12, 2019 19:46
@raymondfeng raymondfeng mentioned this pull request Apr 12, 2019
Merged
7 tasks
@raymondfeng raymondfeng merged commit 62beaef into master Apr 12, 2019
@raymondfeng raymondfeng deleted the resolver-session branch April 12, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabdelgadir nabdelgadir nabdelgadir approved these changes

@bajtos bajtos Awaiting requested review from bajtos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raymondfeng @nabdelgadir