Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve type safety of function calls #2733

Merged
merged 2 commits into from
Apr 12, 2019
Merged

Improve type safety of function calls #2733

merged 2 commits into from
Apr 12, 2019

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Apr 12, 2019

This pull requests contains first two commits from #2704. The changes are needed to pass TypeScript's strictFunctionTypes check.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@bajtos bajtos added refactor IoC/Context @loopback/context: Dependency Injection, Inversion of Control labels Apr 12, 2019
@bajtos bajtos requested a review from raymondfeng April 12, 2019 06:20
@bajtos bajtos self-assigned this Apr 12, 2019
@bajtos bajtos mentioned this pull request Apr 12, 2019
Merged
4 tasks
@raymondfeng raymondfeng merged commit 9e7ea17 into master Apr 12, 2019
@raymondfeng raymondfeng deleted the refactor/improve-type-safety-of-function-calls branch April 12, 2019 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raymondfeng raymondfeng raymondfeng approved these changes

Assignees

@bajtos bajtos

Labels
Examples feature IoC/Context @loopback/context: Dependency Injection, Inversion of Control refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bajtos @raymondfeng