feat(rest): allow - to be used for path template variable names
#2724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondfeng
changed the title
--
|
@raymondfeng, I think some changes in this PR overlaps your other PR #2722. Are we going to abandon #2722, or they are meant to be separate changes? |
Some specs use `{account-id}` as part of the path.
raymondfeng
force-pushed
the
relax-template-varname
branch
from
7fc2800 to
379a4a9
Compare
raymondfeng
changed the title
-- to be used for path template variable names
bajtos
suggested changes
Apr 11, 2019
|
|
||
| it('allows /{foo}-{bar}', () => { | ||
| const path = validateApiPath('/{foo}-{bar}'); | ||
| expect(path).to.eql('/{foo}-{bar}'); |
There was a problem hiding this comment.
Is this a valid OpenAPI path? Will our two router implementations correctly handle such path?
There was a problem hiding this comment.
Good catch. It turns out that - is not allowed by path-to-regexp as it does not match \w. I'll investigate more.
bajtos
added
bug
REST
46 tasks
|
Close this PR with an alternate fix - b6e02fc. |
@raymondfeng How did this commit get into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An OpenAPI spec for banking uses
{account-id}as path variable names. Before this change,@loopback/restreports it as invalid parameter name.Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈