-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(context): clear binding cache upon scope/getValue changes #2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
reviewed
Mar 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this smaller pull request ❤️
I ran of time today, I'll review the changes in more detail tomorrow.
raymondfeng
force-pushed
the
fix-binding-cache
branch
from
March 28, 2019 16:37
36f1803
to
29a748e
Compare
7 tasks
raymondfeng
added
the
IoC/Context
@loopback/context: Dependency Injection, Inversion of Control
label
Mar 28, 2019
bajtos
suggested changes
Mar 29, 2019
raymondfeng
force-pushed
the
fix-binding-cache
branch
from
March 29, 2019 14:36
29a748e
to
7252452
Compare
bajtos
reviewed
Mar 29, 2019
raymondfeng
force-pushed
the
fix-binding-cache
branch
from
March 29, 2019 15:52
dea8854
to
a32b902
Compare
raymondfeng
force-pushed
the
fix-binding-cache
branch
from
March 29, 2019 16:13
a32b902
to
815c23e
Compare
bajtos
approved these changes
Apr 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #2635:
Make sure binding cache is cleared if the binding is bound to a new value provider or scope
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated