-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: scaffold DB migration script for new app projects #2094
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
Do we have any plan to update other example repos like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉. On a side note, should we have the migrate script on other example projects besides Janny already mentioned it :)todo
?
Did I miss anything? |
sorry I found my comment was confusing, what I meant is
I thought other examples in |
As a follow-up for #2059:
Add a template of
migrate.ts
tolb4 app
generator. All new app project will be created withsrc/migrate.ts
now.Further extend
lb4 app
generator to include the following npm/package script:Apply these changes to
examples/todo
andexamples/todo-list
Update
Database migrations
documentation page accordingly.Checklist
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated