Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rest): don't rely on transitive dependencies from express #1918

Merged
merged 1 commit into from
Oct 26, 2018
Merged

fix(rest): don't rely on transitive dependencies from express #1918

merged 1 commit into from
Oct 26, 2018

Conversation

mgabeler-lee-6rs
Copy link
Contributor

Fixes #1917

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

Blank items above because there are no code changes in this PR

Ideally would like this to say, logically, "pull in whatever version of serve-static is used by express", but I'm not sure how to do that.

I've tried to verify this with my problem project where I found the issue, but I can't get pnpm to play nice with linked packages in the context of the rush monorepo. That said, the imports I've added here are exactly the same ones I added to that parent project as a workaround, so I'm reasonably confident this should work.

Note that only including @types/express-serve-static-core and not the base express-serve-static-core is quite intentional and a bit important -- see the issue report for why.

@raymondfeng raymondfeng merged commit a3d5d0c into loopbackio:master Oct 26, 2018
@mgabeler-lee-6rs mgabeler-lee-6rs deleted the fix/1917 branch October 26, 2018 02:36
raymondfeng pushed a commit that referenced this pull request Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants