fix(rest): don't rely on transitive dependencies from express #1918
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1917
Checklist
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updatedBlank items above because there are no code changes in this PR
Ideally would like this to say, logically, "pull in whatever version of
serve-static
is used byexpress
", but I'm not sure how to do that.I've tried to verify this with my problem project where I found the issue, but I can't get
pnpm
to play nice with linked packages in the context of the rush monorepo. That said, the imports I've added here are exactly the same ones I added to that parent project as a workaround, so I'm reasonably confident this should work.Note that only including
@types/express-serve-static-core
and not the baseexpress-serve-static-core
is quite intentional and a bit important -- see the issue report for why.