-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multipart form data #1880
Support multipart form data #1880
Conversation
allow applications to configure body parser options
Hi @goodexpert, thank you for the contribution, this is a great start! IIUC, you are building on top of #1838, thus we will need to land that pull request first, right? Please sign our Contributor License Agreement, we cannot accept your contribution without that. See https://cla.strongloop.com/agreements/strongloop/loopback-next Secondly, we will need you to add automated tests to cover your new feature. I would like to see at least one acceptance test showing how to write a controller method accepting file uploads. Last but not least, the Travis CI build is failing in code-lint and commit-lint steps. You can fix most linting errors by running I highly recommend you to read our DEVELOPING guide to better understand our conventions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☝️
I have fixed some of issue and added an unit testing of multipart/form-data |
@goodexpert thank you for the updates. As I see it, adding support for file uploads is a big feature that will live with us for many months or years and will be difficult to significantly change. I'd like us to carefully design this figure in a way that will be robust, secure and extensible to support future needs. Let's discuss these high-level topics in #1873 first please, before looking at implementation details. |
Is this available? |
Yes, I have applied this to my project to upload files with form data. |
Please check my new pull request. |
Closing in favor of #1989 |
See #1873
Checklist
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated