Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update LB4 status #1859

Merged
merged 1 commit into from
Oct 17, 2018
Merged

docs: update LB4 status #1859

merged 1 commit into from
Oct 17, 2018

Conversation

dhmlau
Copy link
Member

@dhmlau dhmlau commented Oct 16, 2018

In the LB4 docs main page, remove the note about LB4 is still in early development and is not yet released.

@dhmlau dhmlau self-assigned this Oct 16, 2018
{% include important.html content="LoopBack 4 is the next step in the evolution
of LoopBack. It is still in early development and is not yet released.
" %}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of deleting this note, I am proposing to replace it with a note announcing LB 4.0 GA, as we did elsewhere - see e.g. loopbackio/loopback.io#746

{% include note.html content="
LoopBack 4 GA (General Availability) has been released in October 2018,
read more in <a href="http://strongloop.com/strongblog/loopback-4-ga">the announcement post</a>
" %}

Copy link
Contributor

@raymondfeng raymondfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing:

Liquid Exception: Invalid syntax for include tag: content="LoopBack 4 GA (General Availability) has been released in October 2018, read more in <a href="http://strongloop.com/strongblog/loopback-4-ga">the announcement post</a> " Valid syntax: {% include file.ext param='value' param2='value' %} in pages/en/lb4/index.md
jekyll 3.7.3 | Error:  Invalid syntax for include tag:
  content="LoopBack 4 GA (General Availability) has been
released in October 2018, read more in
<a href="http://strongloop.com/strongblog/loopback-4-ga">the announcement
post</a>
"
Valid syntax:
  {% include file.ext param='value' param2='value' %}

@dhmlau dhmlau merged commit 518de09 into master Oct 17, 2018
@dhmlau dhmlau deleted the fix-readme branch October 17, 2018 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants