Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(metadata): remove the default type to work around a TS bug #1774

Merged
merged 1 commit into from
Sep 28, 2018
Merged

fix(metadata): remove the default type to work around a TS bug #1774

merged 1 commit into from
Sep 28, 2018

Conversation

raymondfeng
Copy link
Contributor

@raymondfeng raymondfeng commented Sep 28, 2018 •
edited
Loading

See microsoft/TypeScript#26985
Fixes #1773

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@raymondfeng raymondfeng requested a review from bajtos as a code owner September 28, 2018 18:53
b-admike
b-admike approved these changes Sep 28, 2018
View reviewed changes
Copy link
Contributor

@b-admike b-admike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if it is a workaround, then can we leave a comment with the issue link to remind ourselves to revert it later once it's resolved?

@raymondfeng
Copy link
Contributor Author

There is no need to revert. The new version is more explicit.

@raymondfeng raymondfeng merged commit fc89a2c into master Sep 28, 2018
@raymondfeng raymondfeng deleted the fix-1773 branch September 28, 2018 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-admike b-admike b-admike approved these changes

@virkt25 virkt25 virkt25 approved these changes

@bajtos bajtos Awaiting requested review from bajtos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raymondfeng @virkt25 @b-admike