Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rest): allow controller methods to handle response writing #1760

Merged
merged 1 commit into from
Sep 25, 2018
Merged

feat(rest): allow controller methods to handle response writing #1760

merged 1 commit into from
Sep 25, 2018

Conversation

raymondfeng
Copy link
Contributor

@raymondfeng raymondfeng commented Sep 25, 2018 •
edited
Loading

Follow-up to #1753

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@raymondfeng raymondfeng requested a review from bajtos as a code owner September 25, 2018 16:35
bajtos
bajtos approved these changes Sep 25, 2018
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely 👏

@raymondfeng raymondfeng merged commit 2bfd50e into master Sep 25, 2018
@raymondfeng raymondfeng deleted the bypass-http-response-writing branch September 25, 2018 16:59
@raymondfeng raymondfeng mentioned this pull request Sep 26, 2018
Closed
7 tasks
@bajtos bajtos mentioned this pull request Mar 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raymondfeng @bajtos