feat(testlab): add createRestAppClient(), simplify usage in tests #1734
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing loopbackio/loopback4-example-shopping#12, I noticed the test code is depending on low-level types from
supertest
that are difficult to discover (in my experience). I decided to fix this and introduce a type alias, only to find that we already haveClient
alias defined! As I was replacing supertest type withClient
alias, I found few places callingsupertest
directly instead of using ourcreateClient*
helper APIs and decided to improve that too. Here is the outcome:Client
instead ofsupertest.SuperTest<supertest.Test>
.createClientForRestServer
because it was not used anywhere and had the issue of leaking a listening server (not stopping the server after the test is done).createRestAppClient
instead, rework acceptance tests (including the templates) to use this new helper.Checklist
npm test
passes on your machine/docs/sitetestlab's README was updatedpackages/cli
were updatedexamples/*
were updated