fix(cli): rename repository/service feature flags #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
requested review from
raymondfeng,
virkt25,
marioestradarosa and
a team
- Rename `--enableRepository` to `--repositories`
(notice the plural form)
- Rename `--enableServices` to `--services`
This commit fixes the inconsistency where `--enableRepository` was
using the singular form, while `--enableServices` was using the plural
form.
It also improves the feature prompt so that the word "enable" is not
repeated twice.
Before:
? Select project build settings:
❯◉ Enable tslint
◉ Enable prettier
◉ Enable mocha
◉ Enable loopbackBuild
◉ Enable vscode
◉ Enable enableRepository
◉ Enable enableServices
After:
? Select features to enable in the project:
❯◉ Enable tslint
◉ Enable prettier
◉ Enable mocha
◉ Enable loopbackBuild
◉ Enable vscode
◉ Enable repositories
◉ Enable services
bajtos
force-pushed
the
fix/cli-feature-flags
branch
from
e5e3c12 to
cc8dd14
Compare
shimks
approved these changes
Aug 31, 2018
raymondfeng
approved these changes
Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #1652 and #1649.
--enableRepositoryto--repositories(notice the plural form)--enableServicesto--servicesThis commit fixes the inconsistency where
--enableRepositorywas using the singular form, while--enableServiceswas using the plural form.It also improves the feature prompt so that the word "enable" is not
repeated twice.
Before:
After:
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated