fix: remove extra imports for mixin dependencies #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virkt25
approved these changes
Aug 24, 2018
|
Hmm, I need to fix few more files:
|
With the new TypeScript version, it is no longer necessary to manually import types referenced by mixin classes. This commit removes those extra imports from the CLI template and scaffolded "application.ts" files; and also sorts import using VS Code's feature "Organize imports". While removing unused imports, I cleaned up few more places where we were importing extra types.
bajtos
force-pushed
the
simplify-imports
branch
from
7bac8d8 to
0fc1e93
Compare
bajtos
commented
Aug 24, 2018
| "include": [ | ||
| "benchmark", | ||
| "examples", | ||
| "packages" |
There was a problem hiding this comment.
I have sorted the entries alphabetically.
|
The patch is ready for the final review and landing. @strongloop/sq-lb-apex @raymondfeng PTAL. |
virkt25
approved these changes
Aug 24, 2018
shimks
approved these changes
Aug 24, 2018
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new TypeScript version, it is no longer necessary to manually import types referenced by mixin classes.
This commit removes those extra imports from the CLI template and scaffolded "application.ts" files; and also sorts import using VS Code's feature "Organize imports".
I have discovered this opportunity while working on service-registration mixin (#1439).
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated