docs(testlab): describe Request/Response mocks #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virkt25
reviewed
Jun 4, 2018
packages/testlab/README.md
Outdated
| request & response stubs and a promise to observe the actual response as | ||
| received by clients. | ||
|
|
||
| If your unit under test is expecting a request object only: |
There was a problem hiding this comment.
Don't think that under belongs there.
There was a problem hiding this comment.
@virkt25 In TDD, the phrase "subject under test" used to be pretty common, see e.g. http://xunitpatterns.com/SUT.html
Having said that, I don't really mind how this text is phrased. How should I rewrite this sentence then? Should I change "unit under test" to "tested unit" or "tested function"?
jannyHou
approved these changes
Jun 4, 2018
raymondfeng
approved these changes
Jun 4, 2018
bajtos
force-pushed
the
docs/request-response-mocks
branch
from
a7527a5 to
9031040
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve testlab's README to show how to use
stubServerRequest,stubHandlerContextandstubExpressContextfor mocking/stubbing HTTP request and response objects.Close #760
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated