Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): remove automatic license generation #1198

Merged
merged 1 commit into from
Mar 28, 2018
Merged

fix(cli): remove automatic license generation #1198

merged 1 commit into from
Mar 28, 2018

Conversation

shimks
Copy link
Contributor

@shimks shimks commented Mar 27, 2018 •
edited
Loading

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in packages/example-* were updated

@virkt25
Copy link
Contributor

virkt25 commented Mar 28, 2018

When this lands, please update the March Milestone ticket to include this as a stretch goal :)

@shimks shimks merged commit 537ff86 into master Mar 28, 2018
@shimks shimks removed the review label Mar 28, 2018
@shimks shimks deleted the cli/license branch March 28, 2018 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-admike b-admike b-admike approved these changes

@virkt25 virkt25 virkt25 approved these changes

@raymondfeng raymondfeng raymondfeng approved these changes

@bajtos bajtos Awaiting requested review from bajtos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shimks @virkt25 @raymondfeng @b-admike @0candy