Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove language-related-concepts.md #1157

Merged
merged 1 commit into from
Mar 23, 2018

Conversation

shimks
Copy link
Contributor

@shimks shimks commented Mar 20, 2018

The replacement of content being deleted here is tracked by these issues:

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Related API Documentation was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in packages/example-* were updated

@shimks shimks force-pushed the delete-language-related-concepts branch 3 times, most recently from c13377d to 19a787c Compare March 21, 2018 21:07
@virkt25
Copy link
Contributor

virkt25 commented Mar 22, 2018

As much as I want to see these pages gone, I think it might be better to wait till this content is migrated into a more appropriate doc.

Maybe for the short term it's better to move this under concepts and update the page to say that this is a language related concept but is a pattern used by LoopBack 4.

That said, I'm ok with deleting this if the team agrees. cc: @strongloop/lb-next-dev

@shimks
Copy link
Contributor Author

shimks commented Mar 22, 2018

I may have jumped the gun here with deleting the page. As @virkt25 said, I'd be ok with just migrating mixin.md to key concepts and then deleting language-related-concepts.md

@shimks
Copy link
Contributor Author

shimks commented Mar 22, 2018

Actually, I want to take back what I said. Having taken a look at mixin.md, the code examples it uses make no intuitive sense in context to the framework, and I feel it's better to get rid of the page then it is to mislead users with codes with no practical application.

@b-admike
Copy link
Contributor

I think we could revamp this page to make it relevant to the framework. We can remove it from the sidebar, and leave the page as is until we revisit it. Then again, users can still see it, so perhaps having it in git history and tracked in an issue so we can fix it is good enough.

@shimks shimks force-pushed the delete-language-related-concepts branch 2 times, most recently from 55548ec to f3f87ec Compare March 22, 2018 19:47
@shimks shimks force-pushed the delete-language-related-concepts branch 2 times, most recently from 16dea10 to 88fec86 Compare March 23, 2018 17:30
@shimks shimks force-pushed the delete-language-related-concepts branch from 88fec86 to e02a7c6 Compare March 23, 2018 17:41
@shimks shimks merged commit 16772b1 into master Mar 23, 2018
@shimks shimks deleted the delete-language-related-concepts branch March 23, 2018 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants