-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/finish migration from loopback.io #1141
Conversation
bc33a32
to
ea9da54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great; Thanks for updating them @shimks! I was able to verify that you captured the new files that were added when deleting all the content in loopback.io
(see loopbackio/loopback.io#643 (comment)) and using the script I've been working on to pull the changes from the monorepo as they are now.
ea9da54
to
91ac6b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@b-admike what changes need to be made to the scripts (if any) that pull in LB4 if we are going to move the lb4_sidebar.yml
into the docs
folder here?
@virkt25 it'll just be to move them to their appropriate place, so that references are not broken. Also, @shimks what do you think about moving https://github.com/strongloop/loopback.io/blob/gh-pages/pages/en/lb4/includes/CLI-std-options.md? |
@b-admike I think I want to keep that where is; it's not a file that needs to be changed frequently, and if we do need to change it, we can deal with that when we need to. Speaking of, we may need to componentize or comment your code in update-lb4-docs.js so that it's easier to modify or add other specific files for anyone that may need to add to the script in the future. |
91ac6b6
to
645ea6e
Compare
645ea6e
to
f496919
Compare
Fair enough. I've added comments to the script as you suggested, PTAL :-) |
@raymondfeng Can I get you to sign off on this before I merge it? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought, I'd like us to keep all site related items inside docs/site
(i.e. lb4_sidebar.yml
and tables
). That also means changing the include
blocks in command-line-interface.md
to
{% include_relative tables/lb4-artifact-commands.html %}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick review and didn't find any obvious problems. As far as I am concerned, this patch LGTM.
Please address comments from other reviewers before landing.
@b-admike I agree. l'll make the change |
Could I get a clarification as to why we need to make the change to |
Oh it's because right now they are included from the top level of |
Once we hash out the details in this PR, I'll push up the changes to incorporate what we've done here. |
That sounds good to me, I'll make the changes. |
74dbfaf
to
90e5b29
Compare
There are a couple of stray pages that haven't been migrated and updated over to the monorepo. The PR fixes this
async start
loopback.io#621.html
to.md
Checklist
npm test
passes on your machinepackages/cli
were updatedpackages/example-*
were updated