Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add description of packages for the monorepo #1005

Merged
merged 1 commit into from
Feb 15, 2018
Merged

docs: add description of packages for the monorepo #1005

merged 1 commit into from
Feb 15, 2018

Conversation

raymondfeng
Copy link
Contributor

@raymondfeng raymondfeng commented Feb 15, 2018 •
edited
Loading

Add a table to describe all packages and common tasks for this monorepo.

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Related API Documentation was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in packages/example-* were updated

jannyHou
jannyHou approved these changes Feb 15, 2018
View reviewed changes
Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great to document the command.

@raymondfeng raymondfeng force-pushed the add-packages-md branch 3 times, most recently from 81697cf to c972b0f Compare February 15, 2018 19:08
@raymondfeng raymondfeng merged commit 99ae181 into master Feb 15, 2018
@raymondfeng raymondfeng mentioned this pull request Feb 15, 2018
Merged
6 tasks
@bajtos bajtos deleted the add-packages-md branch February 16, 2018 08:19
@bajtos bajtos mentioned this pull request Feb 19, 2018
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannyHou jannyHou jannyHou approved these changes

@virkt25 virkt25 virkt25 approved these changes

@bajtos bajtos Awaiting requested review from bajtos

@kjdelisle kjdelisle Awaiting requested review from kjdelisle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raymondfeng @virkt25 @jannyHou